fix reduced formula in Ion #2864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the handling of O-H containing compositions, where the string 'HO' was replaced by 'OH' directly in the formula. This will cause some materials, e.g. HSbO2, to have the wrong reduced formula of SbOH2.
for more information, see https://pre-commit.ci
|
Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the handling of O-H containing compositions, where the string 'HO' was replaced by 'OH' directly in the reduced formula. This will cause certain materials, e.g. HSbO2, to have the wrong reduced formula of SbOH2.
This fix then adds a condition that the composition must have an equal number of H and O to be handled that way.