Skip to content

Colorbar label for PDPlotter #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Colorbar label for PDPlotter #2773

merged 2 commits into from
Dec 21, 2022

Conversation

ab5424
Copy link
Contributor

@ab5424 ab5424 commented Dec 13, 2022 •
edited
Loading

Summary

  • Fix cbar label position
  • Update label (colours were only valid for the default colormap)

before and after:
before after

Checklist

  • Doc strings have been added in the Google docstring format. Run pydocstyle on your code.
  • Type annotations are highly encouraged. Run mypy path/to/file.py to type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

@shyuep shyuep enabled auto-merge December 13, 2022 14:07
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling c0b08ec on ab5424:cbar into b9dea8f on materialsproject:master.

@mkhorton mkhorton disabled auto-merge December 21, 2022 18:38
@mkhorton mkhorton merged commit df46a5e into materialsproject:master Dec 21, 2022
@mkhorton
Copy link
Member

Thanks Alexander!

@ab5424 ab5424 deleted the cbar branch December 22, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ab5424 @coveralls @mkhorton