Skip to content

Fix extremum_icohpvalue() for ICOBILIST.lobster files #2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2022
Merged

Fix extremum_icohpvalue() for ICOBILIST.lobster files #2734

merged 3 commits into from
Nov 13, 2022

Conversation

naik-aakash
Copy link
Contributor

@naik-aakash naik-aakash commented Nov 13, 2022 •
edited by janosh
Loading

The value returned by the extremum_icohpvalue() method from Icohplist.icohpcollection instance was wrong for ICOBILIST.lobster file.

  • Fixed the above stated issue
  • Updated the tests to ensure these values are returned correctly

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 823c80d on naik-aakash:fix_icobi_extremum into 607e48d on materialsproject:master.

@naik-aakash
Copy link
Contributor Author

naik-aakash commented Nov 13, 2022 •
edited
Loading

This PR is ready to be merged from my end. Can you please review and merge this @janosh. Also let me know if anything more needs to be done before it could be merged.

@janosh janosh merged commit aae0112 into materialsproject:master Nov 13, 2022
@janosh
Copy link
Member

janosh commented Nov 13, 2022

Thanks @naik-aakash!

@naik-aakash
Copy link
Contributor Author

Thanks @naik-aakash!

You are welcome

@naik-aakash naik-aakash deleted the fix_icobi_extremum branch November 21, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naik-aakash @coveralls @janosh