Skip to content

Fix failing piezo tests #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Fix failing piezo tests #2729

merged 4 commits into from
Nov 9, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 8, 2022

The change in #2727 has resulted in smaller arrays returned by BornEffectiveCharge.get_BEC_operations and ForceConstantMatrix.get_FCM_operations. I think this may be related to the duplication of symmetry ops mentioned in #2725.

This PR updates the test files to match the new output.

  • test_files/piezo_sensitivity/fcmops.npy
  • test_files/piezo_sensitivity/becops.npy

@janosh janosh enabled auto-merge (rebase) November 8, 2022 23:10
@coveralls
Copy link

coveralls commented Nov 8, 2022

Coverage Status

Coverage remained the same at 0.0% when pulling 511364e on fix-failing-piezo-tests into 6b520e3 on master.

@janosh janosh merged commit 6be3535 into master Nov 9, 2022
@janosh janosh deleted the fix-failing-piezo-tests branch November 9, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants