Skip to content

Enable downloads from AWS Open Data for all collections #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Feb 28, 2024

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Feb 16, 2024

This PR enables downloading from AWS Open Data for queries requesting all documents related to a given endpoint.

@munrojm munrojm added release:minor Minor release bump and removed release:minor Minor release bump labels Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 73.98374% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 67.51%. Comparing base (3bc3ac8) to head (5c9b1ec).
Report is 8 commits behind head on main.

Files Patch % Lines
mp_api/client/core/client.py 67.77% 29 Missing ⚠️
mp_api/client/mprester.py 90.00% 2 Missing ⚠️
mp_api/client/routes/materials/similarity.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   67.63%   67.51%   -0.13%     
==========================================
  Files          50       49       -1     
  Lines        2472     2509      +37     
==========================================
+ Hits         1672     1694      +22     
- Misses        800      815      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm added the release:minor Minor release bump label Feb 28, 2024
@munrojm munrojm merged commit daefc5f into main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Minor release bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants