Skip to content

chore: update ssm agent dependency version for al2023 upgrade #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

oycyc
Copy link
Contributor

@oycyc oycyc commented Jul 4, 2024

Update the SSM Agent instance module used for the subnet router, which upgrades to Amazon Linux 2023 from Amazon Linux 2 (masterpointio/terraform-aws-ssm-agent#24)
image

Also update the AWS provider version in the example because the same SSM agent downstream module uses v5 (https://github.com/masterpointio/terraform-aws-ssm-agent/blob/main/versions.tf#L7)

@oycyc oycyc requested a review from a team as a code owner July 4, 2024 21:32
@oycyc
Copy link
Contributor Author

oycyc commented Jul 4, 2024

Rerunning the lint/terrascan, doesn't look to be related to the module:
image

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :shipit: ! I'll bet the lint failure is a transient error with Trunk 👍 We should probably do a trunk upgrade and I'd bet that'll fix it, but we can do that via a separate PR.

@oycyc oycyc merged commit 69e16ca into main Jul 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants