Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clang builds on GitHub Actions #16

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

striezel
Copy link
Contributor

A while ago the ubuntu-latest image moved from Ubuntu 22.04 to Ubuntu 24.04. See actions/runner-images#10636. However, Ubuntu 24.04 does not have packages for Clang 11 and 12 anymore, thus the Clang jobs fail when they try to install the corresponding compilers. Therefore, the workflow is changed to use ubuntu-22.04 instead of ubuntu-latest.

Furthermore, a job for Clang 19 (latest Clang version available on Ubuntu 24.04) is added to run tests with a newer version, too.

(This is basically the same pull request as martinmoene/expected-lite#79 or martinmoene/variant-lite#52, but for scope-lite.)

A while ago the 'ubuntu-latest' image moved from Ubuntu 22.04 to
Ubuntu 24.04. See <actions/runner-images#10636>.
However, Ubuntu 24.04 does not have packages for Clang 11 and 12
anymore, thus the Clang jobs fail when they try to install the
corresponding compilers. Therefore, the workflow is changed to
use 'ubuntu-22.04' instead of 'ubuntu-latest'.

Furthermore, a job for Clang 19 (latest Clang version available
on Ubuntu 24.04) is added to run tests with a newer version, too.
@striezel
Copy link
Contributor Author

striezel commented Mar 20, 2025

Hmm ... The newly added Clang 19 build fails, because it looks like Clang 19 does not have the scope header: https://github.com/martinmoene/scope-lite/actions/runs/13971215629/job/39113255491?pr=16

[ 66%] Building CXX object test/CMakeFiles/scope-lite-cpp20.t.dir/scope-main.t.cpp.o
In file included from /home/runner/work/scope-lite/scope-lite/test/scope-main.t.cpp:9:
In file included from /home/runner/work/scope-lite/scope-lite/test/scope-main.t.hpp:12:
/home/runner/work/scope-lite/scope-lite/include/nonstd/scope.hpp:101:10: fatal error: 'scope' file not found
  101 | #include <scope>
      |          ^~~~~~~

As far as I can see it uses <experimental/scope> instead. I'll see whether I can make scope-lite detect that, too.

Edit:
The attempt to make scope-lite work with <experimental/scope> is now available in pull request #17.

@martinmoene martinmoene merged commit 3817a8c into martinmoene:master Mar 23, 2025
7 of 8 checks passed
@striezel striezel deleted the fix-clang-gha branch March 23, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants