Skip to content

Use PreviewKeyDown instead of KeyUp to handle package list keyboard shortcuts #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

tkohlmeier
Copy link
Contributor

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

I noticed that #3354 does not fully fix #3298 as the package list still uses KeyUp to handle keyboard shortcuts. Moved the key press handling to PreviewKeyDown to fix this.


Relates to #3298

@tkohlmeier tkohlmeier marked this pull request as ready for review March 8, 2025 09:22
@marticliment marticliment merged commit 1862c41 into marticliment:main Mar 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] UniGetUI reacts to key press although not focused
2 participants