Always Update Indexes #3385
Merged
Always Update Indexes #3385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
In attempting to update
bzip2before pressing "update now" to the new 3.1.7 update, the bzip update fails (not due to UniGetUI, but due to vcpkg that was impacted by UniGetUI), and as microsoft/vcpkg#43297 suggests it's because a recent vcpkg commit changed the way the system works, however while commit 9e3482c in #3278 bootstraps vcpkg upon UniGetUI opening (giving it the new version with the updated code), it doesn'tgit pull(as recommended by the above issue, avoiding the configuration being out-of-sync) unless this setting is enabled, causing idiosyncrasies and subtle issues. Things like this was why I hadn't done what 9e3482c did originally, as I've encountered many bugs in the past with different vcpkg versions not working with my current environment. While this is an issue I encountered due to a too-recent vcpkg version, most (if not all) I've encountered were because a new vcpkg version attempted to interact with an old vcpkg directory. This PR should hopefully fix some confusion and prevent some errors, keeping the vcpkg version and directory in sync.