Skip to content

Improvements to icons #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 7, 2024
Merged

Improvements to icons #2945

merged 9 commits into from
Nov 7, 2024

Conversation

marticliment
Copy link
Owner

@marticliment marticliment commented Nov 6, 2024

Improvements to how the icon cache works

  • Improve mimetype detection for URLs without extension filename

    • This fixes .ico files not rendering on Widgets for UniGetUI
    • This allows other-than-png files to be added to the icons and screenshots database
    • This eases handling of different image formats
  • Improvements to the TaskRecycler

    • Fix a race condition that would result with a second task being created when another one was already running but hadn't been added to the dictionary
  • Resize icons for a smaller impact on disk

    • Certain icon formats and sources will be downsized to 256x256

@marticliment marticliment linked an issue Nov 7, 2024 that may be closed by this pull request
6 tasks
@marticliment marticliment marked this pull request as ready for review November 7, 2024 13:04
@marticliment marticliment merged commit 955dde4 into main Nov 7, 2024
2 checks passed
@marticliment marticliment deleted the better-icon-storing-mechanism branch November 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PACKAGE ICONS: Roadmap before releasing
1 participant