-
-
Notifications
You must be signed in to change notification settings - Fork 535
Bunch of f-string, with statements / os.path usage changes #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use f strings as it's better than using string concatenation
Change paths using `os.path.join()` and `os,path.normapth()` for a more robust and platform-independent solution + better readability.
Remove f-string where it's not needed, and add f-string where it's making more sense.
Use `os.path.join()` and `os.path.normpath` for better cross platform comparability and robustness.
Use `os.path.join()` and `os.path.normpath` for better cross platform comparability and robustness.
Use `os.path.join()` and `os.path.normpath` for better cross platform comparability and robustness.
open the contributors file with a `with()` statement instead of closing the file manually.
Use `os.path.join()` for better cross platform comparability and robustness.
Use `os.path.join()` for better cross platform comparability and robustness.
More path changes + use `with()` to open files
Use the `with` statement to open files
Use the `with` statement to open files
@marticliment I think these changes are pretty trivial, do you see any issues with merging them? |
OMG, please try before merge... @marticliment
Btw, whats was wrong before? @Mikey1993 |
This is Windows only app, this commit is useless. (only one is ok, with "with" is no need file close method). 17 commits, 6 changed files, no squash, repeated commit messages... 🤦 |
@marticliment ,Sorry for the mess..
|
I have made changes to the python scripts:
os.path.normpath()
andos.path.join()
where is needed for better cross platform comparability and robustness