Skip to content

Reset CSS columns in advanced background #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Mar 21, 2021

Reported in marp-team/marp#79.

The style for Marpit's advanced background is inheriting from specified CSS theme to keep the layout and design of theme author. However, multi-column layout by CSS Multi-column layout module will break the alignment of images defined by <figure> tag.

Thus, I've added columns: initial !important to the style for <section> with advanced background.

@yhatt yhatt added the bug Something isn't working label Mar 21, 2021
@yhatt yhatt merged commit 8ec1296 into main Mar 25, 2021
@yhatt yhatt deleted the advanced-bg-and-css-columns branch March 25, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant