-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[commonmark] Make link definitions commonmark compliant #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM! (Which probably means I'm missing something somewhere. ;) ) |
Uhm just to be precise: single quotes in link titles are not against the spec. In fact, they are supported by this PR. I forgot about this 🤔 |
About this failing test, it was introduced in c3e0059: I confirm. I should have put a note about this.
are not supported anymore. The rationale is here |
Now that I think about this, it creates a slight incoherence in marked, because it was designed to behave exactly as |
[commonmark] Make link definitions commonmark compliant
I've made link definitions (almost 100%) compliant with the commonmark spec, and added the related test cases, from the spec itself. They all pass, but example 167 has some issue with escaping that needs some attention to be fixed.
This (conflicts with) closes #856,
which goes against the cm spec.