Skip to content

Add pyproject.toml for Custom Node Registry #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

haohaocreates
Copy link
Contributor

@haohaocreates haohaocreates commented May 22, 2024

We are working with dr.lt.data and comfyanon to build a global registry for custom nodes (similar to PyPI). Eventually, the registry will be used as a backend for the UI-manager. All nodes go through a verification process before being published to users.

The main benefits are that authors can

  • publish nodes by version and users can safely update nodes knowing ahead of time if their workflows will break or not
  • automate testing against new commits in the comfy repo and existing workflows through our CI/CD dashboard

Action Required:

  • Go to the registry. Login and create a publisher id. Add the publisher id into the pyproject.toml file.
  • Write a short description.
  • Merge the separate Github Actions PR and run the workflow.

If you want to publish the node manually, install the cli and run comfy node publish

Check out our docs if you want to know more about the registry. Otherwise, feel free to message me on discord at haohao_81202 or join our server if you have any questions!

@haohaocreates
Copy link
Contributor Author

hey @marhensa, wanted to send a small nudge and ask if you had any questions!

@haohaocreates
Copy link
Contributor Author

@marhensa, wondering if there's any way we can support you on this PR!

@marhensa marhensa merged commit f55904f into marhensa:main Jul 7, 2024
@marhensa
Copy link
Owner

marhensa commented Jul 7, 2024

@haohaocreates sorry for the very late response

am I doing it right? I already create publisher id, and add it to pyproject.toml

what another steps should I do? I just don't understand this step "Merge the separate Github Actions PR and run the workflow."

thank you!

@haohaocreates
Copy link
Contributor Author

@haohaocreates sorry for the very late response

am I doing it right? I already create publisher id, and add it to pyproject.toml

what another steps should I do? I just don't understand this step "Merge the separate Github Actions PR and run the workflow."

thank you!

hey! haha we are just saying to "Merge the other PR" that's in your pull requests tab. after you merge that pr, anytime you make a change to this pyproject.toml file, we'll push an updated version of your node to the registry (and eventually this will be a backend for the ui-manager as well!)

lmk if that makes sense 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants