chore(rust): improve build and warnings #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still warnings, but at least they will be more visible. In the future, we should make all this compilable without any warnings.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull Request Overview
This PR improves Rust build configuration and reduces compiler warnings by updating to newer Rust editions, adopting modern string formatting, and standardizing import ordering.
- Updates Rust editions from 2018/2021 to 2024 across crates
- Modernizes string formatting to use inline format specifiers
- Adds workspace-level linting configuration and clippy settings
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/Cargo.toml | Upgrades workspace resolver and adds linting configuration |
| rust/mlt/Cargo.toml | Updates to 2024 edition, adds package metadata, upgrades dependencies |
| rust/wasm-test/Cargo.toml | Updates to 2024 edition |
| rust/clippy.toml | Adds clippy configuration for tests and API breaking changes |
| rust/.gitignore | Expands ignore patterns for development artifacts |
| Multiple .rs files | Modernizes string formatting and standardizes import ordering |
| rust/mlt/justfile | Improves build script robustness and adds debug output |
Comments suppressed due to low confidence (4)
rust/wasm-test/Cargo.toml:4
- Rust edition "2024" does not exist. The latest stable Rust edition is "2021". Consider using "2021" instead.
edition = "2024"
rust/mlt/Cargo.toml:6
- Rust edition "2024" does not exist. The latest stable Rust edition is "2021". Consider using "2021" instead.
edition = "2024"
rust/Cargo.toml:2
- Cargo resolver version "3" does not exist. The latest stable resolver version is "2". Consider using "2" instead.
resolver = "3"
rust/mlt/Cargo.toml:10
- Rust version "1.85.0" may not exist yet. As of January 2025, the latest stable Rust version was around 1.84.x. Please verify this version exists before using it.
rust-version = "1.85.0"
|
I can see plenty of warnings but I understand that's ok for now. |
jjcfrancisco
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still warnings, but at least they will be more visible.
In the future, we should make all this compilable without any warnings.