Skip to content

Run CI tests in Release configuration #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 17, 2022

Conversation

azarovalex
Copy link
Contributor

@azarovalex azarovalex commented Feb 14, 2022

Fixes: #3742
This PR adds two new jobs that run tests in Release configuration with SPM and Carthage integrations respectively.
Some tests had to be disabled since they can only run in Debug configuration.

@azarovalex azarovalex requested a review from a team February 14, 2022 17:50
@@ -677,19 +680,35 @@ workflows:
main-workflow:
jobs:
- build-job:
name: "Xcode_12.5.1_iOS_14.5"
name: "Xcode_12.5.1_iOS_14.5_Debug"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take this as an opportunity to start using Xcode v13.x for some build jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thought about it, I'll try updating to Xcode 13, if we won't need a lot of changes I'll make it in this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode 13 support is being added in another PR: #3728

@azarovalex azarovalex force-pushed the azarovalex/tests-in-release-configuration branch from 395b04e to 6035541 Compare February 14, 2022 22:29
@mapbox-github-ci-issues-public-1

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-public-1

No breaking changes detected in MapboxNavigation

@@ -6,6 +6,7 @@ import MapboxSpeech
import MapboxNavigation
import MapboxCommon_Private

#if DEBUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a comment on why we don't run some tests in the Release configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the billing API used in these tests was already wrapped in #if DEBUG, for security reasons.

Run CI jobs on Xcode 13.2.1 and iOS 15.2
@mapbox-github-ci-issues-public-1

No breaking changes detected in MapboxCoreNavigation

@mapbox-github-ci-issues-public-1

No breaking changes detected in MapboxNavigation

@azarovalex azarovalex merged commit 0506d35 into main Feb 17, 2022
@azarovalex azarovalex deleted the azarovalex/tests-in-release-configuration branch February 17, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI tests in Release configuration
3 participants