Implement FixLocation.provider field based on CLLocationSourceInformation #3728
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,7 +92,25 @@ class CLLocationTests: TestCase { | |
| speedAccuracy: speedAccuracy, | ||
| timestamp: timestamp) | ||
| } | ||
| #if compiler(>=5.5) | ||
| if #available(iOS 15.0, *) { | ||
| let sourceInfo = CLLocationSourceInformation( | ||
| softwareSimulationState: true, | ||
| andExternalAccessoryState: false | ||
| ) | ||
|
Comment on lines
+96
to
+100
There was a problem hiding this comment. Despite this
|
||
| location = CLLocation(coordinate: coordinate, | ||
| altitude: altitude, | ||
| horizontalAccuracy: horizontalAccuracy, | ||
| verticalAccuracy: verticalAccuracy, | ||
| course: bearing, | ||
| courseAccuracy: bearingAccuracy, | ||
| speed: speed, | ||
| speedAccuracy: speedAccuracy, | ||
| timestamp: timestamp, | ||
| sourceInfo: sourceInfo) | ||
| } | ||
| #endif | ||
|
|
||
| let fixLocation = FixLocation(location) | ||
|
|
||
| XCTAssertEqual(fixLocation.coordinate.latitude, coordinate.latitude) | ||
|
|
@@ -108,6 +126,11 @@ class CLLocationTests: TestCase { | |
| XCTAssertEqual(fixLocation.bearingAccuracy?.doubleValue, bearingAccuracy) | ||
| XCTAssertEqual(fixLocation.speedAccuracy?.doubleValue, speedAccuracy) | ||
| } | ||
| #if compiler(>=5.5) | ||
| if #available(iOS 15.0, *) { | ||
| XCTAssertEqual(fixLocation.provider, "sim:1,acc:0") | ||
| } | ||
| #endif | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps MapboxNavigationNative could be modified to accept something more structured like a dictionary instead of a freeform, user agent–like string, so that it can format and compress it as appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should add something iOS-specific - there is no analog of this structure on other platforms. Since this value will be used as kind of debug information I think it is okay to have it in this
providerfield in a free form. Btw initially I implemented it as a part ofFixLocation.extrasfield, which allows to add any additional information to locations, but then decided thatprovideris exactly that field that was supposed to use for such use case(i.e. point to the source of location). WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant a JSON-like dictionary of strings, similar to that
extrasfield. But if you’re sure we won’t ever need additional structure beyond this format, then we can go with this more opaque string.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we will need JSON here, I'd prefer to save bytes in history here rather than adding JSON overhead, because we likely need this data for debugging only.