Skip to content

fix/fallback data #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

fix/fallback data #402

merged 1 commit into from
Mar 22, 2022

Conversation

b-pmcg
Copy link
Collaborator

@b-pmcg b-pmcg commented Mar 22, 2022

Link to Shortcut ticket:

https://app.shortcut.com/dux-makerdao/story/1214/fix-exec-loading-time

What does this PR do?

Update fallback option to fallbackData

Any additional helpful information?:

See this discussion
Docs

@b-pmcg b-pmcg changed the base branch from develop to master March 22, 2022 17:48
@b-pmcg b-pmcg requested review from rafinskipg and adamgoth March 22, 2022 17:48
@vercel
Copy link

vercel bot commented Mar 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dux-core-unit/governance-portal-v2/HpmVeks6UZt1v8xHxzsW3wWtdeLP
✅ Preview: https://governance-portal-v2-git-fix-fallback-data-dux-core-unit.vercel.app

@b-pmcg b-pmcg merged commit 571b5e9 into master Mar 22, 2022
@b-pmcg b-pmcg deleted the fix/fallback-data branch March 22, 2022 19:07
b-pmcg added a commit that referenced this pull request Mar 22, 2022
* try pre-building a smaller amount of pages with static paths (#388) (#390)

* try pre-building a smaller amount of pages with static paths

* Remove unused imports

Co-authored-by: Rafael Ventura <[email protected]>

Co-authored-by: Phil Bain <[email protected]>

* use fallbackData option to display pre-fetched execs before loading more (#402)

Co-authored-by: Venture <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants