Add missing optional fields to LinkMentionResponse #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public API link mention response only includes href and not other supported attributes
This document is a template for reporting bugs and user issues. It includes sections for describing the problem, expected behavior, troubleshooting steps, and reproduction steps. It also has a section for attaching supporting visuals and links to a user issue tracker. The document is low priority and has only one user report. |
mquan
approved these changes
Mar 12, 2025
ksinder
added a commit
that referenced
this pull request
Mar 12, 2025
Ran `npm version patch` This new version tag will include the changes from #550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK
src/api-endpoints.tswith Notion's latest Public API spec.Changes:
LinkMentionResponse, all of which are optional:title,description,link_author,link_provider,thumbnail_url,icon_url,iframe_url,height,padding,padding_top