Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Whitelisting/Blacklisting Functionality in mailcow UI #6444

Open
wants to merge 10 commits into
base: staging
Choose a base branch
from

Conversation

PhoenixPeca
Copy link
Contributor

Contribution Guidelines

What does this PR include?

Include the local resolver IP in the python code instead of blindly relying on resolver config from the base image OS to have it (Alpine)..

Short Description

Without this PR, the whitelist and blacklist functionality from mailcow UI doesnt work:
image

Container netfilter-mailcow log:
image

Affected Containers

  • netfilter-mailcow

Did you run tests?

Yes, locally... This PR now allows netfilter to get the list of blacklist and whitelist from mailcowUI via fail2ban, see screenshot below.
image

What did you tested?

netfilter-mailcow container tested to see if Exception still occurs after this change... This update fixed it.

What were the final results? (Awaited, got)

Got the expected behavior... Bug fixed.

FreddleSpl0it and others added 10 commits January 23, 2025 12:01
[Nginx] move conf.d include to end of nginx.conf
…ges (mailcow#6273)

* clamd: update to 1.4.2 + build from source instead using alpine packages

* clamd: remove exposed ports from buildfile

* clamd: cleanup dockerfile
Include the local resolver IP in the python code instead of blindly relying on resolver config from the base image OS..
@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@PhoenixPeca PhoenixPeca changed the base branch from master to staging April 1, 2025 04:44
@PhoenixPeca PhoenixPeca changed the title Fix local resolver error... Fix Broken Whitelisting/Blacklisting Functionality in Mailcow UI Apr 1, 2025
@PhoenixPeca
Copy link
Contributor Author

Hi @FreddleSpl0it @DerLinkman , i hope you can take time to check into this if this fix works for you.. :D I'm happy to be contributing updates again into mailcow-dockerized project.. It's been a while hahaha!

@PhoenixPeca PhoenixPeca changed the title Fix Broken Whitelisting/Blacklisting Functionality in Mailcow UI Fix Broken Whitelisting/Blacklisting Functionality in mailcow UI Apr 1, 2025
@PhoenixPeca
Copy link
Contributor Author

PhoenixPeca commented Apr 1, 2025

@FreddleSpl0it , This PR supersedes #6438 , which I believe aims to resolve another issue with the recent alpine upgrade... Let me know if this is worth merging as a fix or if you prefer to do an Alpine downgrade.

@FreddleSpl0it
Copy link
Collaborator

@PhoenixPeca, I think this PR remains helpful even with the Netfilter downgrade. The underlying issue hasn’t been resolved by the downgrade. I just haven’t had the time to properly investigate it yet.

@PhoenixPeca
Copy link
Contributor Author

Hi @FreddleSpl0it , awesome! Let me know if you need anything else to get this included on the next release... Thanks a lot! :D

@FreddleSpl0it FreddleSpl0it added the neverstale Bot doesn't mark the issue or PR as stale label Apr 7, 2025
@FreddleSpl0it
Copy link
Collaborator

@PhoenixPeca I will check and merge this PR for the next release (not minor release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neverstale Bot doesn't mark the issue or PR as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants