-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Broken Whitelisting/Blacklisting Functionality in mailcow UI #6444
base: staging
Are you sure you want to change the base?
Conversation
[Nginx] move conf.d include to end of nginx.conf
…ges (mailcow#6273) * clamd: update to 1.4.2 + build from source instead using alpine packages * clamd: remove exposed ports from buildfile * clamd: cleanup dockerfile
Update 2025-01a
Update 2025-02
Update 2025-02
Update 2025-03
Update 2025-03a
Include the local resolver IP in the python code instead of blindly relying on resolver config from the base image OS..
Hi @FreddleSpl0it @DerLinkman , i hope you can take time to check into this if this fix works for you.. :D I'm happy to be contributing updates again into mailcow-dockerized project.. It's been a while hahaha! |
@FreddleSpl0it , This PR supersedes #6438 , which I believe aims to resolve another issue with the recent alpine upgrade... Let me know if this is worth merging as a fix or if you prefer to do an Alpine downgrade. |
@PhoenixPeca, I think this PR remains helpful even with the Netfilter downgrade. The underlying issue hasn’t been resolved by the downgrade. I just haven’t had the time to properly investigate it yet. |
Hi @FreddleSpl0it , awesome! Let me know if you need anything else to get this included on the next release... Thanks a lot! :D |
@PhoenixPeca I will check and merge this PR for the next release (not minor release). |
Contribution Guidelines
What does this PR include?
Include the local resolver IP in the python code instead of blindly relying on resolver config from the base image OS to have it (Alpine)..
Short Description
Without this PR, the whitelist and blacklist functionality from mailcow UI doesnt work:

Container netfilter-mailcow log:

Affected Containers
Did you run tests?
Yes, locally... This PR now allows netfilter to get the list of blacklist and whitelist from mailcowUI via fail2ban, see screenshot below.

What did you tested?
netfilter-mailcow container tested to see if Exception still occurs after this change... This update fixed it.
What were the final results? (Awaited, got)
Got the expected behavior... Bug fixed.