Fix php 8.1 deprecation issues caused by preg_replace error #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fascinosum
reviewed
Dec 10, 2021
Comment on lines
+202
to
+203
| // this preg_replace may return NULL in case of error (PREG_BACKTRACK_LIMIT_ERROR). | ||
| // In that case the result of this method will be an empty string. |
There was a problem hiding this comment.
Suggested change
| // this preg_replace may return NULL in case of error (PREG_BACKTRACK_LIMIT_ERROR). | |
| // In that case the result of this method will be an empty string. | |
| // this preg_replace call can return NULL in case of error (PREG_BACKTRACK_LIMIT_ERROR). | |
| // In this case, the result of this method will be an empty string. |
|
@magento import code to magento-trigger/zf1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the deprecation warning on PHP 8.1 (passing null to preg_replace), which is caused by the previous preg_replace returning NULL (due to PREG_BACKTRACK_LIMIT_ERROR).
This fix should be rolled back after we fix the regular expression (L198).
The main issue described here:
(TBD Here will be the link to the ticket)