Fixes for PHP 8.1 compatibility #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karyna-t
force-pushed
the
php8.1-compatibility/fixes
branch
2 times, most recently
from
e010510 to
95f04f4
Compare
andrewbess
approved these changes
Nov 3, 2021
karyna-t
force-pushed
the
php8.1-compatibility/fixes
branch
from
95f04f4 to
72bc347
Compare
karyna-t
force-pushed
the
php8.1-compatibility/fixes
branch
from
469212b to
5364d08
Compare
xmav
approved these changes
Nov 17, 2021
fascinosum
requested changes
Nov 18, 2021
karyna-t
force-pushed
the
php8.1-compatibility/fixes
branch
from
2685e14 to
59ddff2
Compare
karyna-t
changed the title
karyna-t
force-pushed
the
php8.1-compatibility/fixes
branch
from
59ddff2 to
a79c8ec
Compare
fascinosum
requested changes
Nov 22, 2021
fascinosum
requested changes
Nov 23, 2021
| @@ -134,14 +134,17 @@ protected function _prepare($sql) | |||
| */ | |||
| protected function _parseParameters($sql) | |||
| { | |||
| $sql = $this->_stripQuoted($sql); | |||
There was a problem hiding this comment.
I recommend leaving it as it is
| // split into text and params | ||
| $this->_sqlSplit = preg_split('/(\?|\:[a-zA-Z0-9_]+)/', | ||
| $sql, -1, PREG_SPLIT_DELIM_CAPTURE|PREG_SPLIT_NO_EMPTY); | ||
| if ($sql !== null) { |
There was a problem hiding this comment.
How will the following foreach be executed if $sql === null?
| @@ -134,7 +132,6 @@ public function getExtension() | |||
| */ | |||
| public function setExtension($extension) | |||
| { | |||
| $this->_extension = null; | |||
There was a problem hiding this comment.
I think
$this->_extension = '';
is more appropriate
There was a problem hiding this comment.
Hello @fascinosum
The property $_extension is '' by default
There was a problem hiding this comment.
Only right after initialization of the object
fascinosum
approved these changes
Nov 24, 2021
fascinosum
reviewed
Nov 29, 2021
library/Zend/Db/Statement/Pdo.php
Outdated
| @@ -245,7 +245,7 @@ public function _execute(array $params = null) | |||
| * @return mixed Array, object, or scalar depending on fetch mode. | |||
| * @throws Zend_Db_Statement_Exception | |||
| */ | |||
| public function fetch($style = null, $cursor = null, $offset = null) | |||
| public function fetch($style = null, $cursor = PDO::FETCH_ORI_NEXT, $offset = 0) | |||
There was a problem hiding this comment.
Please move these operations to the method code
andrewbess
force-pushed
the
php8.1-compatibility/fixes
branch
from
bbbc1c8 to
438053d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Issues were found when trying to launch Magento, and running Unit Tests, on php-8.1. env.
This PR is fixing Zend code to be compatible with PHP 8.1.
Related Pull Requests
Related Issues