Skip to content

Changed live search and PREX to public packages #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

del22123
Copy link
Collaborator

@del22123 del22123 commented Jul 8, 2025

Description

Updated live search and PREX to public packages

TODO: Updated live search and PREX to public packages

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del22123 del22123 requested a review from glo82145 July 8, 2025 13:29
@del22123 del22123 self-assigned this Jul 8, 2025
@del22123 del22123 added the version: Patch This changeset includes backwards compatible bug fixes. label Jul 8, 2025
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 8, 2025

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-8bb27a85.json

Generated by 🚫 dangerJS against d534cd5

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 8, 2025

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • contains valid CMS Page data:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays subcategories from the default root category:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    displays assigned products:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,contains valid CMS Page data specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows categories specific to the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false


    shows products specific to the categories in the different store:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

    ,lets users add products to cart regardless of store view:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4495.pwa-venia.com/

      The response we received from your web server was:

      504: Gateway Timeout

      This was considered a failure because the status code was not 2xx.

      If you do not want status codes to cause failures pass the option: failOnStatusCode: false

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d534cd5

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d534cd5

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against d534cd5

@glo82145 glo82145 closed this Jul 8, 2025
@glo82145 glo82145 reopened this Jul 8, 2025
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-a21d1b6c.json

Generated by 🚫 dangerJS against d534cd5

glo82145
glo82145 previously approved these changes Jul 8, 2025
@glo82145 glo82145 changed the base branch from release/14.3 to develop July 8, 2025 15:52
@glo82145 glo82145 dismissed their stale review July 8, 2025 15:52

The base branch was changed.

@glo82145 glo82145 changed the base branch from develop to release/14.3 July 8, 2025 15:54
@glo82145
Copy link
Collaborator

glo82145 commented Jul 8, 2025

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 8, 2025

Successfully started codebuild job for pr-deploy

@glo82145 glo82145 closed this Jul 9, 2025
@glo82145 glo82145 deleted the PWA-3511-v6 branch July 9, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:extensions version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants