Skip to content

Fixing Jumping Issue on PLP and SRLP #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

del15881
Copy link
Collaborator

@del15881 del15881 commented Jul 3, 2025

Description

Fixing the Page Jumping Issue on PLP and SRLP by fixing how variables are updated.

TODO: Describe your changes in detail here.

Related Issue

https://jira.corp.adobe.com/browse/PWA-3476

Closes #PWA-3476.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@del15881 del15881 requested a review from glo82145 July 3, 2025 08:23
@del15881 del15881 added the bug Something isn't working label Jul 3, 2025
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d42f03b

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d42f03b

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Jul 3, 2025

Fails
🚫

node failed.

🚫

Unable to create scaffolded project.

DEBUG_PROJECT_CREATION=1 packages/create-pwa/bin/create-pwa

failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖

Associated JIRA tickets: PWA-3476.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against d42f03b

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

Error: Error: Cannot find module './.lighthouseci/assertion-results.json'
Require stack:
- dangerfile.lighthouse.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js
- /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js

ERROR ON TASK: lighthouseTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results-99235a7c.json

Generated by 🚫 dangerJS against d42f03b

@del15881 del15881 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Jul 3, 2025
@glo82145
Copy link
Collaborator

glo82145 commented Jul 4, 2025

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 4, 2025

Successfully started codebuild job for pr-test

@glo82145
Copy link
Collaborator

glo82145 commented Jul 4, 2025

run scaffold-pwa

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 4, 2025

Successfully started codebuild job for scaffold-pwa

@glo82145
Copy link
Collaborator

glo82145 commented Jul 4, 2025

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 4, 2025

Successfully started codebuild job for pr-test

@glo82145
Copy link
Collaborator

glo82145 commented Jul 4, 2025

run pr-test

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jul 4, 2025

Successfully started codebuild job for pr-test

@del15881
Copy link
Collaborator Author

del15881 commented Jul 4, 2025

closing this PR as changes are merged from #4487.

@del15881 del15881 closed this Jul 4, 2025
@glo82145 glo82145 deleted the bugfix/PWA-3476-Live-Search-Jump-Fix branch July 9, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:extensions version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants