Skip to content

Fixed InjectAViewModel validation #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fixed InjectAViewModel validation #370

merged 1 commit into from
Nov 3, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Nov 3, 2020 •
edited by coderimus
Loading

Description (*)

Fixed Viewmodel argument name validation as per reported issue

Fixed Issues (if relevant)

  1. Fixes Change the validation of the Argument Name field in the ViewModel dialog window #369: Change the validation of the Argument Name field in the ViewModel dialog window

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@coderimus coderimus self-assigned this Nov 3, 2020
@coderimus coderimus self-requested a review November 3, 2020 16:37
@coderimus coderimus added the Easy label Nov 3, 2020
@coderimus coderimus merged commit 90ad884 into magento:2.1.0-develop Nov 3, 2020
@DmitryFurs
Copy link
Contributor

@drpayyne can you backport it to 2.0.2 ?

@drpayyne
Copy link
Contributor Author

drpayyne commented Nov 5, 2020

@VitaliyBoyko and @coderimus, backporting this bugfix is a bit different than others. Two ways to do it

  • Change the validator type to annotations like in 2.1.0-develop and fix the bug
  • Fix this bug directly in the old validator type which uses a class

Which would be the preferred way for this backport? I'll work on it once you confirm. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderimus coderimus coderimus approved these changes

Assignees

@coderimus coderimus

Labels
Easy partners-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the validation of the Argument Name field in the ViewModel dialog window
4 participants
@drpayyne @DmitryFurs @coderimus @magento-engcom-team