406: added sorting plugin list marker #1121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
It was added by sorting the plugin parkers depending on it's "before" "around" or "after" plugin, and by the sortOrder attribute value.
But it was not included in sorting by the module sequence. Here we should add the parsing
config.php
file and provide an array with the module name and sequence value. Please to implement it was added the note@TODO
at the thecom.magento.idea.magento2plugin.linemarker.php.PluginLineMarkerProvider.PluginClassCache#getPluginMethods(java.util.List<com.magento.idea.magento2plugin.stubs.indexes.data.PluginData>)
Actual results:
In the first file, you can see the list sorted by sortOrder value and the correct list for the
after
plugin after around.In the second file, you can see that the vendor plugin, which has no
sortOrder
attribute has the highest priority.2022-06-28.21.33.04.mov
Questions or comments
To compleat this part we here need add the module sequence condition: the logic to sort is implemented, need just add module sequence value.
Also in the future will be good mark the area of plugins list:
Contribution checklist (*)