Skip to content

613: Added possibility to compare overridden template with the original one #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexstpp
Copy link

@alexstpp alexstpp commented Mar 16, 2022

Description (*)

Added posibility to compare current template with original one.

Screenshot 2022-03-16 at 18 34 36

Screenshot 2022-03-16 at 18 35 03

Fixed Issues (if relevant)

  1. Fixes Add possibility to navigate from an overridden template inside of a custom theme directly to the original one #613

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bohdan-harniuk bohdan-harniuk changed the title 613 diff overridden template 613: Added possibility to compare overridden template with the original one Mar 16, 2022
@bohdan-harniuk bohdan-harniuk self-requested a review March 16, 2022 16:37
@bohdan-harniuk bohdan-harniuk self-assigned this Mar 16, 2022
@bohdan-harniuk
Copy link
Collaborator

bohdan-harniuk commented Mar 17, 2022

Hello, @alexstpp!

Thank you for your work here! It is really great!

I've found two exceptions:

  1. comparison is available for module templates (unexpected behaviour) + it is not supported by the code and it resulting in a critical error
  2. another critical error shown while comparing theme template with the original one

Action shown for the module template:

Screenshot 2022-03-17 at 14 15 49

Critical exception while calling the action for the module template:

Screenshot 2022-03-17 at 14 16 51

Critical exception while calling the action for the theme template:

Screenshot 2022-03-17 at 16 07 58

ℹ️ I've fixed showing the action for the module template:

image

ℹ️ Results after code refactoring:

image

Screenshot 2022-03-17 at 16 16 44-min

Please, take a look at my changes.

Regards,

bohdan-harniuk
bohdan-harniuk previously approved these changes Mar 17, 2022
Copy link
Collaborator

@bohdan-harniuk bohdan-harniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @alexstpp!

Thank you for your work!

Regards,

@bohdan-harniuk bohdan-harniuk force-pushed the 613-diff-overridden-template branch from 55c525d to 4cee5c5 Compare March 17, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to navigate from an overridden template inside of a custom theme directly to the original one
2 participants