refactor: job isolation done #204

Mohiiit · 2025-01-22T06:14:51Z

files and information needed by each job should be provided by the worker of the respective job, no inter-job dependency

crates/orchestrator/src/constants.rs

crates/orchestrator/src/jobs/da_job/mod.rs

crates/orchestrator/src/jobs/snos_job/mod.rs

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/orchestrator/src/database/mongodb/mod.rs

crates/orchestrator/src/jobs/metadata.rs

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/orchestrator/src/jobs/state_update_job/utils.rs

crates/orchestrator/src/workers/data_submission_worker.rs

crates/orchestrator/src/workers/proving.rs

crates/orchestrator/src/workers/update_state.rs

coveralls · 2025-01-31T22:00:39Z

coverage: 65.521% (-0.7%) from 66.239%
when pulling c648a2f on refactor/job-isolation
into 640fa53 on main.

heemankv

Please feel free to make separate issues for comments you don't feel fit to resolve in this PR, please also add the issue link in the respective comment.

Note: I have skipped through reading the tests this time

crates/orchestrator/src/constants.rs

crates/orchestrator/src/database/mongodb/mod.rs

crates/orchestrator/src/jobs/metadata.rs

crates/orchestrator/src/jobs/da_job/mod.rs

crates/orchestrator/src/jobs/state_update_job/utils.rs

crates/orchestrator/src/jobs/state_update_job/mod.rs

crates/prover-clients/atlantic-service/src/lib.rs

crates/prover-clients/sharp-service/src/lib.rs

crates/orchestrator/src/database/mongodb/mod.rs

crates/orchestrator/src/tests/workers/utils/mod.rs

Mohiiit added 2 commits January 22, 2025 11:43

refactor: job isolation done

e703bff

fix: tests fixed

ff84440

apoorvsadana reviewed Jan 22, 2025

View reviewed changes

Mohiiit added 2 commits January 23, 2025 16:03

feat: metadata struct introduced

decc1ad

refactor: metadata introduced to each job, happy flow working

d11c246

apoorvsadana reviewed Jan 24, 2025

View reviewed changes

crates/orchestrator/src/workers/data_submission_worker.rs Outdated Show resolved Hide resolved

crates/orchestrator/src/workers/proving.rs Outdated Show resolved Hide resolved

crates/orchestrator/src/workers/update_state.rs Outdated Show resolved Hide resolved

Mohiiit added 4 commits January 31, 2025 11:22

chore: comments resolved

a35594a

fix: e2e test should work

7336d08

fix: fixing the snos fact

37cff7a

chore: linting and e2e test

d0f2e34

Mohiiit and others added 5 commits February 1, 2025 03:47

fix: snos full output set to false in e2e

11d3be9

chore: linting

b1ba517

chore: linting, and addressing a few comments

9c2c64f

Merge branch 'main' into refactor/job-isolation

e3dcaea

chore: docs added

04e9324

heemankv suggested changes Feb 12, 2025

View reviewed changes

Mohiiit and others added 12 commits March 4, 2025 11:06

chore: comments resolved

ac2ee05

refactor(tests): all tests updated with the latest metadata changes

fe0f37a

refactor: metadata refactored

d490a65

Merge branch 'main' into refactor/job-isolation

3408e91

chore: fixing post merge

d7603bd

chore(ci): fixing the workflow to use rustup show

e4acd86

chore(ci): fixing the rustup command

f46286d

chore(ci): fixing the test ci

93d0db6

chore(ci): fixing the coverage and e2e workflows

11cf440

chore(ci): reverting to initial version

bb6f271

fix(ci): coverage workflow updated v1

d25b21d

fix(ci): coverage workflow updated v2

4a2c548

Mohiiit added 10 commits March 5, 2025 02:14

fix(ci): coverage workflow updated v3

de27ab8

fix(ci): coverage workflow updated v4

a2ee8de

fix(ci): coverage workflow updated v5

114043b

fix(ci): coverage workflow updated v6

fcc9bde

fix(ci): coverage workflow updated v7

dd03ea6

chore(fix): tests fixed and ci workflow fixed for e2e

639084d

fix(test): state update create job test fixed

685daf1

chore(e2e): test time fixed and expectedDBState updated

4fcbf71

refactor: constants fixed

f5a123e

refactor(tests): build job item moved to common

c648a2f

eenthiran approved these changes Mar 7, 2025

View reviewed changes

crates/orchestrator/src/database/mongodb/mod.rs Show resolved Hide resolved

crates/orchestrator/src/database/mongodb/mod.rs Show resolved Hide resolved

crates/orchestrator/src/tests/workers/utils/mod.rs Show resolved Hide resolved

This was referenced Mar 7, 2025

Standardize job_id usage in tracing #209

Open

Let's use recursion here! #210

Open

heemankv approved these changes Mar 8, 2025

View reviewed changes

heemankv merged commit 272b013 into main Mar 8, 2025
9 checks passed

Mohiiit mentioned this pull request Mar 19, 2025

Update Orchestrator to Latest Changes and Prepare for Future L3 Support madara-alliance/madara#524

Merged

refactor: job isolation done #204

refactor: job isolation done #204

Uh oh!

Conversation

Mohiiit commented Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

heemankv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Jan 31, 2025 •

edited

Loading