icon: Update to 9.5.24b

[Dave-Allured]

Description

• Switch to github portgroup, and github named tags.
• Remove x11 variant as default. Not working currently.
• Porting is incomplete. See discussion in https://trac.macports.org/ticket/71946.

Type(s)

Tested on

CI only. OS 13, 14, 15 only.

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[cooljeanius]

instead of commenting this out, maybe instead conditionalize it depending on whether it works or not?

[Dave-Allured]

No. This port's entire configuration system needs repair. That is the priority. So far, this has evaded all my attempts. X11 will start working just fine, after configuration gets fixed. See the referenced ticket.

[cooljeanius]

ok, so maybe put this in draft mode until it does start working, then?

[Dave-Allured]

Yeah I thought about that. This responds to a current user request. I figured that a port that would actually build and offer something possibly working on current OS versions, is better than the status quo, a completely broken and outdated port. What do you think?

[reneeotten]

the use of github.setup should be corrected.

More importantly, this doesn't solve any of the issues in the Trac ticket. You can/should start by using the makefile PortGroup and then setting use_configure yes. That will do some things correctly but the build fails later on; I don't have the time/interest to follow through on that, but you could...

[reneeotten]

this should be:

github.setup        gtownsend icon 9.5.24 v b

and then the lines below for master_sites and distname need to be removed

[Dave-Allured]

github.setup gtownsend icon 9.5.24 v b

and then the lines below for master_sites and distname need to be removed

Done. Thanks for advice, I had a lot of trouble figuring this out because of GitHub magic renaming of the fetch URL.

[Dave-Allured]

More importantly, this doesn't solve any of the issues in the Trac ticket. You can/should start by using the makefile PortGroup and then setting use_configure yes. That will do some things correctly but the build fails later on; I don't have the time/interest to follow through on that, but you could...

@reneeotten I added the makefile PortGroup and use_configure yes. Now the CI builds are working with the X11 variant disabled as default.

I kept X11 disabled because it still fails due to an incorrect include path for X11. Will this be sufficient to merge now, and leave X11 debugging for later?