Skip to content

libdiscid: fix universal 32/64-bit build #28923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sideeffect42
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
  • macOS 12.7.6 21H1320 x86_64
    Xcode 14.2 14C18
  • Mac OS X 10.5.8 9L31a Power Macintosh
    Xcode 3.1.4 9M2809
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Dennis Camera added 2 commits July 20, 2025 23:16
e.g. on a ppc+ppc64 universal build the following error appeared and DiscID computation was incorrect:

    CC       src/sha1.lo
  src/sha1.c: In function ‘sha_transform’:
  src/sha1.c:129: warning: right shift count >= width of type
@sideeffect42 sideeffect42 force-pushed the devel/libdiscid/fix-3264-universal branch from b95c530 to bbdbb9a Compare July 20, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants