Skip to content

dosbox: fix build where it breaks due to invalid suffix #28911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrbrandao
Copy link

  • Adding a small patch to fix the dosbox emulator build, where it breaks with: error: invalid suffix on literal; C++11 requires a space between literal and identifier
  • This small patch will add the space to address C++11 requirement, an alternative fix could be change the build flag -Wreserved-user-defined-literal

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

MaxOSX 10.11.6
Xcode none / Command Line Tools 8.2.0.0.1.1480973914

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* Adding a patch to fix the dosbox emulator build, where it breaks
  with: `error: invalid suffix on literal; C++11 requires a space between
  literal and identifier`
* This small patch will add the space to address C++11 requirement,
  an alternative fix could be change the build flag
  `-Wreserved-user-defined-literal`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants