update nodejs portfiles, enable ccache, use macports libraries where possible #28819

i3roly · 2025-07-07T00:21:59Z

please see my follow-up to @ryandesign's ticket here:

https://trac.macports.org/ticket/71475#comment:17

as it stands, with the forthcoming pull this is the status:

nodejs14->nodejs20 will build/run properly on all macs that have a newer libuv (i'm on 10.14, so i dunno where the line is)
nodejs14->nodejs18 will build/run properly on all macs from 10.7 and newer
whilst the logs on the ticket aren't showing ccache, i did test it on nodejs18 on lion (as we speak) and it looks fine. i see no reason why ccache should cause a problem.

the outstanding issues are now:

fixing libuv for nodejs20->nodejs22 on older macs
fixing/updating macports-libcxx so more-recent macs (like 10.14 machines) can run nodejs22

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.7.5 11G63 x86_64
Xcode 4.6.2 4H1003

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL in commit message?
checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?
checked that the Portfile's most important variants haven't been broken?

macportsbot · 2025-07-07T00:22:02Z

Notifying maintainers:
@ci42 for port nodejs14, nodejs16, nodejs18, nodejs20, nodejs22.

i3roly · 2025-07-08T04:45:54Z

added libuv @ryandesign

i hate git so much. you guys can deal with this nonsense.

building nodejs20 on lion while i pass out

later

…nto TheRemix

this is a well-known bug on lion that relates to posix_spawn and FD_CLOEXEC, which only works on 10.8 and above (maybe 10.6 too, not sure)

i3roly · 2025-07-08T12:05:47Z

provided nodejs20/zettlr build log to show the panic issue has been fixed.

i would appreciate any contributor's adjustments to the version macros to ensure they're working right.

in short, for libuv:

the sendmsg_x recvmsg_x calls should only be compiled for 10.15 and higher
the FD_CLOEXEC flag for posix spawn should only be included for 10.8 and higher.

seems to work by using an older-style. also use the CloseallFDsOnExec that originated in chrome, which will close all FDs after execution. though they say it's not safe in multithreaded applications, it worked for quite some time and is better than nothing. all that's left is ensuring clang-19 uses the latest ld throughout. seems to call ld127 at the end :/

- also make all systems use the up-to-date macports libuv, for uniformity.

casr · 2025-07-12T09:55:17Z

@i3roly Potentially some of what you're bringing up here was solved in #27671 if you want to give it a test?

since there's some discussion as to whether libuv or libuv-devel will be getting the update, i have copied the patch to both versions. as it stands a newer libuv is needed for some ports. it may make sense to just use libuv-devel for node at this time.

it looks like buildbot already takes care of this or something?

ryandesign

These are only the things that stood out to me in your nodejs14 changes. I didn't look at the other ports.

ryandesign · 2025-07-16T23:53:18Z

lang/nodejs14/Portfile

+    file mkdir ${workpath}/zlib-inc ${workpath}/cares-inc
+    file copy ${prefix}/include/zconf.h ${prefix}/include/zlib.h \
+        ${workpath}/zlib-inc/
+    system "cp ${prefix}/include/*ares*.h ${workpath}/cares-inc"


It's preferable to use native Tcl code when possible instead of using system. In this case, this can probably be done with (untested):

Suggested change

system "cp ${prefix}/include/*ares*.h ${workpath}/cares-inc"

copy {*}[glob ${prefix}/include/*ares*.h] ${workpath}/cares-inc

whoops i thought i had incorporated this, but i'll do this at the end with the outstanding libuv 'tarball' -> release change

ryandesign · 2025-07-16T23:53:43Z

lang/nodejs14/Portfile


 # V8 only supports ARM and IA-32 processors
 supported_archs         i386 x86_64 arm64

 universal_variant       no

-# "V8 doesn't like cache."
-configure.ccache        no
+configure.ccache        yes


This is the default; you could remove this line.

Suggested change

configure.ccache yes

ryandesign · 2025-07-17T00:02:00Z

lang/nodejs14/Portfile

 depends_lib-append      path:lib/pkgconfig/icu-uc.pc:icu \
-                        port:python${py_ver_nodot} \
-                        port:zlib
+                        path:lib/libz.dylib:zlib \


Unless something changed while I wasn't looking, the zlib port is the only port that installs lib/libz.dylib, so there's no reason to change port:zlib to path:lib/libz.dylib:zlib.

dun.

and you were right: it was a nodejs issue. seems certain versions had this header, but older and newer ones did not lol. so typical of these guys lol

ryandesign · 2025-07-17T00:08:22Z

lang/nodejs14/Portfile

-                        port:zlib
+                        path:lib/libz.dylib:zlib \
+                        path:lib/libuv.dylib:libuv \
+                        port:openssl \


This port includes the openssl portgroup so you're not supposed to have to include the openssl dependency yourself; the portgroup does it for you.

Suggested change

port:openssl \

ryandesign · 2025-07-17T00:10:25Z

lang/nodejs14/Portfile

+configure.args-append   --shared-openssl-includes=${prefix}/libexec/openssl3/include/openssl
+configure.args-append   --shared-openssl-libpath=${prefix}/libexec/openssl3/lib


This port includes the openssl portgroup so it was correct to use its functions to get the include and library paths; that should not have been changed.

Suggested change

configure.args-append --shared-openssl-includes=${prefix}/libexec/openssl3/include/openssl

configure.args-append --shared-openssl-libpath=${prefix}/libexec/openssl3/lib

configure.args-append --shared-openssl-includes=[openssl::include_dir]

configure.args-append --shared-openssl-libpath=[openssl::lib_dir]

Since it looks like you want to switch from openssl 1.1 to 3, change this line near the top of the Portfile:

openssl.branch 1.1

i actually didn't care what openssl version was used, but you are right i should just use the macros that come with the portgroup. so that's what i did.

i didn't change openssl's inclusion otherwise.

ryandesign · 2025-07-17T00:11:48Z

lang/nodejs14/Portfile

 set py_ver              3.10
 set py_ver_nodot        [string map {. {}} ${py_ver}]

+depends_build-append    port:pkgconfig


The build is failing because python310 was not found.

Suggested change

depends_build-append port:pkgconfig

depends_build-append port:pkgconfig \

port:python${py_ver_nodot}

ryandesign · 2025-07-17T00:26:49Z

devel/libuv/Portfile

+    revision    1
+    checksums   rmd160  40cf693021f7584ff4aeffcbf2020d0e00139005 \
+                sha256  2ceca1a7577633cf92794db5bf5512370f6cd45a5746d6e14f8c20aeab0a547b \
+                size   1691252 


This doesn't look like it's aligned correctly, and it has trailing whitespace.

Suggested change

size 1691252

size 1691252

However, please follow the instructions in the comment and change github.tarball_from from tarball to either releases or archive, whichever is correct for this software; then the checksums will change again.

Since you are increasing the version, the revision should be 0.

i will do this change at the very end because of the volume of other things that were changed.

like the star on the top of the tree, we will put it on together, my dear rydye @ryandesign

ryandesign · 2025-07-17T00:31:28Z

Responding to the question you asked in a commit message:

remove autoreconf command for libuv-devel
it looks like buildbot already takes care of this or something?

Buildbot and GitHub Actions run MacPorts. MacPorts does not automatically use autoreconf. If this software needs autoreconf to be done, or if you are patching files that comprise an autoconf-based build system, the portfile must run autoreconf.

i3roly · 2025-07-17T00:33:12Z

well when i was testing locally it did require autoconf, but its' possible that macports is grabbing it correctly and i was doing something wrong. i assume i was doing it wrong because that error went away once i removed the autoconf calls.

…

On Jul 16, 2025, at 6:31 PM, Ryan Carsten Schmidt ***@***.***> wrote: ryandesign left a comment (macports/macports-ports#28819) Responding to the question you asked in a commit message: remove autoreconf command for libuv-devel it looks like buildbot already takes care of this or something? Buildbot and GitHub Actions run MacPorts. MacPorts does not automatically use autoreconf. If this software needs autoreconf to be done, or if you are patching files that comprise an autoconf-based build system, the portfile must run autoreconf. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

thanks pal. proud to announce the new spiffy macports-libcxx holds up well to all of the nodejses, unlike the existing one which cannot cope with the lack of __cxa_thread_atexit, whereas mine, whilst not fully there (i would like the symbol pulled automatically from the dylib instead of shoehorning in the static), can pull the symbol out of the static libcxxabi.

well, i blew it because i didn't put in ${prefix} instead of /opt/local when linking libc++abi.a, so i have to hope this is the star on the tree commit here's to hoping it works

this is more of a 'touch' commit than anything, because buildbot reports macos 13 building fine, so i don't know why 14/15 wouldn't also be okay unless it has to do with my decision to force update stale commits. so here is a fresh commit to see if clears buildbot's confusion

i3roly · 2025-07-18T11:49:38Z

everything looks good @ryandesign
i have no idea why it failed on 14/15, but it looks like a header clash?

maybe it was my decision to amend previous commits that previously were missing things.

i just pushed a fresh commit to rule this out. i don't see why 14/15 would have errors if 13 is ok.

@ryandesign

yes yes rydye @ryandesign i may have missed the slightly-different patch for nodejs16, and i may have forgotten the include directives for zlib on nodejs24, which probably would explaint he failures on both hoping for all green baby let's go

weirdness

@jmroot

whatever CMON LET'S GO ALL GREEN i got a few tracks queued up for the occasion, rootie @jmroot

@jmroot

there was "regression" in clang20 at some point, and i assume the snapshot of APPUL clang contained it, as the other two don't fail on nodejs24 (well, at least 15 doesn't on the last run). so we force clang-19 on macos15 for nodejs24. rootie @jmroot if this finishes when i'm in bed (and you'll obviously be up and at it), wait to crack those Fosters kegs cc @ryandesign

clang-mp-19 here's to hoping. the only outstanding issue is macos14 and nodejs24

@ryandesign

hoping this works. otherwise i need your input @ryandesign as to how to force nodejs24+macos14 to use clang-mp-19. i assume i should have been using configure.{cc,cxx,cpp} to force them all along, and not compiler.blacklist

i3roly · 2025-07-19T17:29:02Z

rootie @jmroot is that Fosters on ice? has it even arrived?

i guess i can use Jet - Hey kids as the pre-drink/primer.

cc @ryandesign looks like we good to go fam.

time to flip them switches like daz and kurupt and get this show ROLLIN'

update nodejs portfiles and shit

56fbc4a

macportsbot assigned ci42 Jul 7, 2025

macportsbot added type: enhancement type: update maintainer: open Affects an openmaintainer port labels Jul 7, 2025

i3roly added 3 commits July 6, 2025 18:27

just some tidying

165106d

add fixes so libuv builds on 10.6/10.7 looks ok?

eab67c3

Merge branch 'macports:master' into TheRemix

c6f4e20

i3roly added 4 commits July 8, 2025 05:23

update nodejs20 portfile to use shared libuv

ae6ea83

Merge branch 'master' of https://github.com/macports/macports-ports i…

d75efdc

…nto TheRemix

Merge branch 'TheRemix' of https://github.com/i3roly/macports-ports i…

8a4c2e6

…nto TheRemix

add fix so libuv does not panic on 10.7

beff156

this is a well-known bug on lion that relates to posix_spawn and FD_CLOEXEC, which only works on 10.8 and above (maybe 10.6 too, not sure)

i3roly added 2 commits July 8, 2025 07:48

tidy up nodejs portfiles

0e6c6e2

- also make all systems use the up-to-date macports libuv, for uniformity.

i3roly added 2 commits July 12, 2025 08:48

fix nodejs20+ so they use libuv-devel as opposed to libuv

abbc1f5

i3roly force-pushed the TheRemix branch from 1f89fb8 to abbc1f5 Compare July 12, 2025 15:10

fix errors in dependencies for nodejs, and small fix to libuv

89e4c2e

i3roly force-pushed the TheRemix branch from f3e6a67 to 89e4c2e Compare July 13, 2025 19:04

add patches for nodejs on 10.6

0d62391

i3roly force-pushed the TheRemix branch from efd2585 to 0d62391 Compare July 16, 2025 02:16

i3roly added 2 commits July 16, 2025 07:24

fix libuv checksum so buildbot stops bugging out

8fa142a

remove autoreconf command for libuv-devel

dfa2d15

it looks like buildbot already takes care of this or something?

ryandesign reviewed Jul 17, 2025

View reviewed changes

i3roly force-pushed the TheRemix branch from 7d495f2 to b6ef247 Compare July 17, 2025 22:36

add remaining changes recommended by @ryandesign

f43c73c

well, i blew it because i didn't put in ${prefix} instead of /opt/local when linking libc++abi.a, so i have to hope this is the star on the tree commit here's to hoping it works

i3roly force-pushed the TheRemix branch from afc4dfd to f43c73c Compare July 18, 2025 03:33

i3roly added 2 commits July 18, 2025 10:40

stupid zlib, or stupid me. whatever

2be6619

yes yes rydye @ryandesign i may have missed the slightly-different patch for nodejs16, and i may have forgotten the include directives for zlib on nodejs24, which probably would explaint he failures on both hoping for all green baby let's go

dummy commit

466f95f

i3roly force-pushed the TheRemix branch from e2fd173 to 466f95f Compare July 18, 2025 16:51

i3roly added 2 commits July 18, 2025 16:03

is it really the checksum thing?

fe64118

weirdness

i'm stupid i'm stupid i'm stupid @ryandesign

027e7ad

whatever CMON LET'S GO ALL GREEN i got a few tracks queued up for the occasion, rootie @jmroot

i3roly force-pushed the TheRemix branch from 0f3c613 to 550baa2 Compare July 19, 2025 01:38

i3roly force-pushed the TheRemix branch from 550baa2 to 2845c64 Compare July 19, 2025 01:39

i3roly added 2 commits July 19, 2025 01:18

try to blacklist clang++/clang/macports-clang-20 to ensure we use

8047be3

clang-mp-19 here's to hoping. the only outstanding issue is macos14 and nodejs24

ok let's try it this way and see if it's any better

d65e184

hoping this works. otherwise i need your input @ryandesign as to how to force nodejs24+macos14 to use clang-mp-19. i assume i should have been using configure.{cc,cxx,cpp} to force them all along, and not compiler.blacklist

	system "cp ${prefix}/include/ares.h ${workpath}/cares-inc"
	copy {}[glob ${prefix}/include/ares*.h] ${workpath}/cares-inc

		configure.args-append --shared-openssl-includes=${prefix}/libexec/openssl3/include/openssl
		configure.args-append --shared-openssl-libpath=${prefix}/libexec/openssl3/lib

	depends_build-append port:pkgconfig
	depends_build-append port:pkgconfig \
	port:python${py_ver_nodot}

Uh oh!

update nodejs portfiles, enable ccache, use macports libraries where possible #28819

Are you sure you want to change the base?

update nodejs portfiles, enable ccache, use macports libraries where possible #28819

Uh oh!

Conversation

i3roly commented Jul 7, 2025 • edited by ryandesign Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type(s)

Tested on

Verification

Uh oh!

macportsbot commented Jul 7, 2025

Uh oh!

i3roly commented Jul 8, 2025

Uh oh!

i3roly commented Jul 8, 2025

Uh oh!

casr commented Jul 12, 2025

Uh oh!

ryandesign left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryandesign Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryandesign commented Jul 17, 2025

Uh oh!

i3roly commented Jul 17, 2025 via email

Uh oh!

i3roly commented Jul 18, 2025

Uh oh!

i3roly commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

i3roly commented Jul 7, 2025 •

edited by ryandesign

Loading

ryandesign Jul 17, 2025 •

edited

Loading

i3roly commented Jul 19, 2025 •

edited

Loading