Skip to content

fix MySQL replication status aquisition bug #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

takaidohigasi
Copy link
Contributor

@takaidohigasi takaidohigasi commented Feb 21, 2023

WHY

mackerel-plugin-mysql fails on replica status aquisition (MySQL major version is not related)
#7

WHAT

fix replica status aquisition bug ( to work with current show slave status format: 1 row response)

NOTE

  • show slave status returns only 1 row (which has multiple columns) but former implementation assume it is multiple rows like show status query
  • there isn't test for replica metric (also for this test) but I confirmed the test.sh on my localhost
taka-h@H37R9YYYGV mackerel-plugin-mysql % bash test.sh
cba1da4cf1213b79f8bdd5cc9e394c2e55f7ef2324b23c656cfd7d4e94125594
Connecting 1...
test-mackerel-plugin-mysql
test-mackerel-plugin-mysql
taka-h@H37R9YYYGV mackerel-plugin-mysql % echo $?
0

@takaidohigasi takaidohigasi marked this pull request as ready for review February 21, 2023 07:02
@takaidohigasi
Copy link
Contributor Author

@yseto would you please take a look when you have time?

@takaidohigasi takaidohigasi changed the title fix MySQL replication status aquisiiton bug fix MySQL replication status aquisition bug Feb 24, 2023
@lufia
Copy link
Member

lufia commented Feb 24, 2023

I will review this pull request ASAP.

@lufia
Copy link
Member

lufia commented Feb 27, 2023

@takaidohigasi Thanks! We will release new version in the next few days.

@lufia lufia merged commit d6a364d into mackerelio:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants