Skip to content

Replace driver #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 14, 2023
Merged

Replace driver #2

merged 11 commits into from
Feb 14, 2023

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Feb 6, 2023

  • use go.mongodb.org/mongo-driver
  • fix test script

yseto added 2 commits February 6, 2023 10:28
@yseto
replace driver.
6f528cb 
- use go.mongodb.org/mongo-driver
- fix test script
@yseto
added multiple version tests.
6f7ce5e
@yseto yseto self-assigned this Feb 6, 2023
@yseto yseto marked this pull request as ready for review February 8, 2023 08:50
Base automatically changed from remove-docker-test to main February 9, 2023 11:58
Arthur1
Arthur1 reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a good idea to switch to another driver. I pointed out the command line interface.

@yseto yseto requested a review from Arthur1 February 14, 2023 03:57
Arthur1
Arthur1 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to us.

@yseto yseto merged commit 3051220 into main Feb 14, 2023
@yseto yseto deleted the replace-driver branch February 14, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arthur1 Arthur1 Arthur1 approved these changes

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yseto @Arthur1