Skip to content

update neo-engine and refactor task stop handling #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

OutOfBedlam
Copy link
Contributor

This pull request includes several changes aimed at improving the task management and script execution in the mods/tql module, as well as updating dependencies and adding new test cases. The most important changes are summarized below:

Task Management Improvements:

  • mods/tql/task.go: Introduced _shouldStopListeners to allow adding listeners that get notified when a task should stop. Added AddShouldStopListener method and updated fireCircuitBreak to notify listeners. [1] [2]

Script Execution Enhancements:

Dependency Updates:

  • go.mod: Updated github.com/machbase/neo-engine/v8 to a newer version v8.0.42-0.20250321110958-66bd4ea52df8.

New Test Cases:

Benchmark Updates:

  • test/bench_test.go: Added new benchmark results for different CPUs and updated the benchmark functions with the latest performance data. [1] [2]

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.25%. Comparing base (f59f342) to head (ba57866).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   41.13%   41.25%   +0.12%     
==========================================
  Files         262      262              
  Lines       57943    57945       +2     
==========================================
+ Hits        23834    23906      +72     
+ Misses      31741    31663      -78     
- Partials     2368     2376       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OutOfBedlam OutOfBedlam merged commit 5e5a854 into main Apr 11, 2025
10 checks passed
@OutOfBedlam OutOfBedlam deleted the work/js-script-tc branch April 11, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant