Skip to content

geomap opt includes initial position #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

geomap opt includes initial position #300

merged 1 commit into from
Mar 24, 2025

Conversation

OutOfBedlam
Copy link
Contributor

This pull request focuses on refactoring the way initial map bounds and view settings are applied in the GeoMap module and its related test files. The changes involve using an opt object to store initialization parameters for better organization and maintainability.

Key changes include:

Refactoring map initialization:

Updates in test files:

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.21%. Comparing base (b5b2e32) to head (ed8cc3d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mods/codec/internal/geomap/geomap.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   41.21%   41.21%           
=======================================
  Files         261      261           
  Lines       57373    57375    +2     
=======================================
+ Hits        23644    23645    +1     
- Misses      31383    31384    +1     
  Partials     2346     2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OutOfBedlam OutOfBedlam merged commit 7d7ec72 into main Mar 24, 2025
10 checks passed
@OutOfBedlam OutOfBedlam deleted the geomap-init-pos branch March 24, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant