geomap opt includes initial position #300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the way initial map bounds and view settings are applied in the
GeoMap
module and its related test files. The changes involve using anopt
object to store initialization parameters for better organization and maintainability.Key changes include:
Refactoring map initialization:
mods/codec/internal/geomap/geomap.go
: Modified theClose
method to useopt.initBounds
andopt.initPoint
for setting map bounds and view.Updates in test files:
mods/codec/internal/geomap/test/geomap_polygon.html
: Updated to useopt.initPoint
for setting the initial map view.mods/codec/internal/geomap/test/geomap_test.html
: Changed to useopt.initBounds
for fitting map bounds.mods/codec/internal/geomap/test/geomap_test_geojson.html
: Refactored to useopt.initBounds
for fitting map bounds.mods/tql/test/js-geojson-point.js
: Updated to useopt.initPoint
for setting the initial map view.