-
Notifications
You must be signed in to change notification settings - Fork 3
Current aggregator selected as changed by fallthrough logic is not reflected in the options page #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The aggregator options are encoded in a |
The fallthrough logic does not appear to work correctly in the main branch but in testing the issue-316 branch (MV3), the logic works (the ODUCS response is malformed) but does not accomplish what this issue (#369) describes. Moving this issue to be a sub-issue of #316, as it ought to be included in the next release, of which #316 is the blocker. |
Rather, we'll bundle them both under a separate issue (#372) |
The fallthrough logic is working fine, but this value still is not sticky and the new default is not shown when viewing the options page after this logic has run.
200144f has some logic to set the default aggregator in localStorage when the fallthrough is invoked, but the new default is not shown in the re-ordered options.js page. That dropdown might be hard-coded rather than fetched from localStorage. Update: It is hardcoded in the options.html. This should be dynamic with a fallback default of the hard-coded values. |
Largely driven by the changes in #316 via #367, Mink has an option of a series of aggregators for archival sources. If the first one is down, the logic will change to querying the second one.
I am not sure whether the runtime logic persists for subsequent runs but the fall-through, subsequent aggregator is not indicated as the default in the options tab.
This requires some logical work but also UI considerations, e.g.,
The text was updated successfully, but these errors were encountered: