chore: restrict torch version to below 2.4 in dependencies (fix the libcudnn dependencies common issue) #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim60105
changed the title
torch depends on libcudnn9 from version 2.4.0 onward. If we restrict torch<2.4.0, there is no need to manually install libcudnn8 and also save about 1GB disk space. - Update torch dependency to be below version 2.4.0 instead of at least 2.5.1 - Change torchaudio dependency to have no minimum version specified Signed-off-by: CHEN, CHUN <[email protected]>
- Restrict the onnxruntime dependency to versions >=1.19 and <1.20.0 to avoid potential compatibility issues. Signed-off-by: CHEN, CHUN <[email protected]>
…n README" This reverts commit 6fe0a87. Revert the commit now that the issue is fixed. Signed-off-by: CHEN, CHUN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit cd59f21 downgraded ctranslate2 to version 4.4.0, meaning we will remain on cudnn8.
torch depends on libcudnn9 from version 2.4.0 onward.
If we restrict torch<2.4.0, there is no need to manually install libcudnn8 and also save about 1GB disk space.
This PR:
Related #1087, #1158