Fix for crash in alignment when called with no tokens #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worked for me, thanks EDIT: I was using version 3.3.1 |
|
I haven't had this issue since upgrading to v3.3.2. Is it still necessary to address it? |
|
I was using version 3.3.1, I did not try with 3.3.2. However in alignment.py, get_wildcard_emission() is the same in both versions so it might be worth it to add this fix (unless the bug has been fixed in another part of the code) Thank you for your work anyway :) |
bjollans
added a commit
to bjollans/whisperX
that referenced
this pull request
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048
There are probably better ways to do this but this change restores previous behavior which worked before changes from 65b2332
-> when called with empty list of tokens return empty tensor