contemplate single table inheritance in DeviseTokenAuth::Concerns::SetUserByToken#set_user_by_token #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tUserByToken#set_user_by_token
|
Good catch @maxwells. I'll merge once we get one more approval |
lynndylanhurley
approved these changes
Oct 19, 2017
|
This makes sense to me from reading the PR and issue. Seems that is_a is a bit less restrictive class check. I'm going to merge. |
|
@zachfeldman @lynndylanhurley when are you folks considering another release? |
|
@johnnagro ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contemplate single table inheritance in DeviseTokenAuth::Concerns::SetUserByToken#set_user_by_token
addresses #982 for the Dockwa organization
cc @johnnagro