Skip to content

Feature/customable authorized users only error response #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 7, 2017
Merged

Feature/customable authorized users only error response #869

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5f8e4db
parge error-rendering to method in authenticate_{mapping}!
abeyuya Apr 14, 2017
6b1da15
parge group-error-rendering to method in authenticate_{group_name}!
abeyuya Apr 14, 2017
82590f9
add explain comment about new method
abeyuya Apr 14, 2017
fef2bf8
add new method exist test
abeyuya Apr 14, 2017
68facd4
modify comment for explaining generated method
abeyuya Apr 20, 2017
ed4ebc3
merge master and resolve conflict about error message
abeyuya Jun 25, 2017
9dcc414
change error-render method name
abeyuya Jun 25, 2017
5ae32a8
remove duplicate tests and modify bad test name
abeyuya Jun 25, 2017
1b141ce
add test
abeyuya Jun 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/devise_token_auth/controllers/helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def current_#{group_name.to_s.pluralize}

def render_authenticate_#{group_name}_error
return render json: {
errors: ["Authorized #{group_name} only."]
errors: [I18n.t('devise.failure.unauthenticated')]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved conflict about error message.

}, status: 401
end

Expand Down Expand Up @@ -131,10 +131,10 @@ def current_#{mapping}
def #{mapping}_session
current_#{mapping} && warden.session(:#{mapping})
end

def render_authenticate_#{mapping}_error
return render json: {
errors: ["Authorized #{mapping} only."]
errors: [I18n.t('devise.failure.unauthenticated')]
}, status: 401
end
METHODS
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.