Skip to content

Fix critical error on registration with confirmation mode #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 15, 2021
Merged

Fix critical error on registration with confirmation mode #1447

merged 8 commits into from
Mar 15, 2021

Conversation

pnghai
Copy link
Contributor

@pnghai pnghai commented Dec 10, 2020

In case confirmation is activated:

  • When more than 1 user registered, the 'uid' column will be left empty until confirmation complete. That will lead to duplication of 'uid-provider' index as uid are both nulled but providers are the same 'email'

@pnghai pnghai changed the title Fix critical error on registration case Fix critical error on registration with confirmation mode Dec 10, 2020
@MaicolBen
Copy link
Collaborator

Can you add a test confirming the bug?

@Hoss3770
Copy link

The problem appeared again in version 1.1.4 with rails 6.1

@MaicolBen MaicolBen merged commit a9904e5 into lynndylanhurley:master Mar 15, 2021
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@rafahuaman rafahuaman mentioned this pull request May 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnghai @MaicolBen @Hoss3770