Skip to content

Require mocha >= 1.5 #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2018
Merged

Require mocha >= 1.5 #1169

merged 1 commit into from
May 28, 2018

Conversation

krzysiek1507
Copy link
Contributor

Require mocha >= 1.5 to fix #1149

@MaicolBen MaicolBen requested a review from Evan-M May 15, 2018 23:42
Evan-M
Evan-M approved these changes May 16, 2018
View reviewed changes
Copy link
Collaborator

@Evan-M Evan-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

As an aside, it still seems to me like it would be better to remove mocha entirely. ¯\_(ツ)_/¯

@krzysiek1507
Copy link
Contributor Author

krzysiek1507 commented May 16, 2018 •
edited
Loading

I'll also take a look and try to remove unused gems (e.g. figaro, thor).

@krzysiek1507
Copy link
Contributor Author

krzysiek1507 commented May 28, 2018 •
edited
Loading

Can we merge it?

@MaicolBen MaicolBen merged commit 047fe4f into lynndylanhurley:master May 28, 2018
@krzysiek1507 krzysiek1507 deleted the maintenance/update-mocha branch May 28, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evan-M Evan-M Evan-M approved these changes

@MaicolBen MaicolBen MaicolBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mocha/minitest issue in test_helper.rb
3 participants
@krzysiek1507 @Evan-M @MaicolBen