-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor token creation #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor token creation #1061
Conversation
It might be a good idea to avoid the use of |
Thanks, but that applies to instance variables, you can't share two method variables unless you create a thread inside that method. |
@MaicolBen sorry I haven't seen this yet! I approve of this line of thought and your changes. Fix your conflicts and we should be good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks @MaicolBen!!
239d8f5
to
32fe65b
Compare
32fe65b
to
ccf06c2
Compare
Are the two instance methods in Additionally, I would think that UPDATE: I realize that this comment is not as clear as I had intended. Thus I have created a new PR #1098. |
I didn't know if I should include
@resource.save!
in the new method, also method name suggestions are appreciated.