Skip to content

Restore reset password tokens behavior #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2017
Merged

Restore reset password tokens behavior #1017

merged 1 commit into from
Nov 14, 2017

Conversation

dks17
Copy link
Contributor

@dks17 dks17 commented Nov 13, 2017 •
edited
Loading

Please see Reset Password Tokens No Longer Expire #1008

@dks17 dks17 mentioned this pull request Nov 13, 2017
Closed
@stratigos
Copy link
Contributor

stratigos commented Nov 13, 2017 •
edited
Loading

Following the discussion in #1008, this still forces the default use case (i.e., not Mongoid) to make a local override to handle helpful error messages (all fails return a generic 404).

Forget what I wrote above - this is change actually makes it easier to handle reset pw expired error messages, vs the state of #edit prior to #957.

Pls move forward with this PR as pw reset expiry needs fixed! Thx!

@zachfeldman
Copy link
Contributor

These changes make sense to me. Merging

@zachfeldman zachfeldman merged commit 0e3fb2c into lynndylanhurley:master Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dks17 @stratigos @zachfeldman