E-mail confirmations sent twice (duplicate emails)

[develop-test1]

Gem version: 0.1.38 (as well as from master branch latest)

Rails version: 5.0.0 API

This version resolves #500, however it introduces error where same confirmation e-mail is sent twice, once the auth POST register action is performed resulting in duplicate e-mail sending.

MailCatcher screenshot:

It is also worth noting that this only happens for confirmation e-mails. Password reset e-mails are sent once as expected.

[develop-test1]

I found out that removing these lines in registrations_controller fixes the problem and confirmation e-mails are sent once:

  unless @resource.confirmed?
              # user will require email authentication
              # @resource.send_confirmation_instructions({
              #   client_config: params[:config_name],
              #   redirect_url: @redirect_url
              # })

            else

[develop-test1]

Opened-up pull request: #678

[develop-test1]

Other way to fix this problem is to include this in the user model:

  before_create :skip_duplicate_devise_confirmation_email

# Fixes problem with duplicate account confirmation emails
  def skip_duplicate_devise_confirmation_email
    skip_confirmation_notification!
  end

[brunowego]

@develop-test1 your solution works for me.

[MaicolBen]

#678 got it fixed, closing