Skip to content

Cannot send confirmation email when using alongside with standard devise #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ysyyork opened this issue Nov 30, 2015 · 5 comments
Closed

Comments

@ysyyork
Copy link

ysyyork commented Nov 30, 2015

I want to use standard devise alongside with devise token auth. When signing up users with standard devise, I found the confirmation email cannot be sent. However, email works well when signing up with devise token auth. #229 discussed something about this but as a noob, unfortunately, I cannot understand what's going on here as the discussion is so short. Is there a way to enable email confirmation when using standard devise? I believe this happens because devise token gem modifies some parts of the registration controller in standard devise.

@zentetsukenz
Copy link

I see the code here https://github.com/lynndylanhurley/devise_token_auth/blob/master/app/models/devise_token_auth/concerns/user.rb#L121
states that "this must be done from the controller so that additional params can be passed on from the client"

So, the quick fix would be add the method called send_confirmation_notification? and return true to your user's model.

But the problem is I cannot find any documentation here about send_confirmation_notification?. Would be nice if someone explain more about this.

@adis-io
Copy link
Contributor

adis-io commented Jun 27, 2016

I ended up using this gist:
https://gist.github.com/adisos/248da0b1a520b8d85726c2ec224d885e

@zachfeldman
Copy link
Contributor

Sounds like we have a solution, so closing this for now.

@mbandrewfoster
Copy link

So that gist is gone, what was the actual solution?

@webzorg
Copy link

webzorg commented Dec 11, 2019

defining this method inside devise_token_auth like this def send_confirmation_notification?; false; end is OUTRAGEOUS!

for reference
devise_token_auth-1.1.3/app/models/devise_token_auth/concerns/user.rb @ line 113:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants