Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incusd/instance/qemu: Skip to link nvram to itself #1760

Merged
merged 1 commit into from
Mar 16, 2025
Merged

incusd/instance/qemu: Skip to link nvram to itself #1760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/server/instance/drivers/driver_qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2220,11 +2220,18 @@ func (d *qemu) setupNvram() error {
return err
}

nvramPath := d.nvramPath()

// Handle the case where the firmware vars filename matches our internal one.
if efiVarsName == filepath.Base(nvramPath) {
return nil
}

// Generate a symlink.
// This is so qemu.nvram can always be assumed to be the EDK2 vars file.
// The real file name is then used to determine what firmware must be selected.
_ = os.Remove(d.nvramPath())
err = os.Symlink(efiVarsName, d.nvramPath())
_ = os.Remove(nvramPath)
err = os.Symlink(efiVarsName, nvramPath)
if err != nil {
return err
}
Expand Down