incus/file: Properly handle relative source paths

When going through either .Split() or .Base(), a source path of ".." is
incorrectly treated as an empty source directory and so processed the
same as ".".

This is obviously incorect behavior which then leads to files landing in
the wrong directory on the server side.

I couldn't find a good way with pure filepath calls to handle this, so
instead we've got to hardcode the logic for the parent paths.
Any path containing a separator (/) are handled correctly though.

Closes #1808

Signed-off-by: Stéphane Graber <[email protected]>

Author: stgraber

cmd/incus/file.go

@@ -1180,9 +1180,15 @@ func (c *cmdFile) recursivePullFile(sftpConn *sftp.Client, p string, targetDir s
 
 func (c *cmdFile) recursivePushFile(sftpConn *sftp.Client, source string, target string) error {
 	source = filepath.Clean(source)
+
 	sourceDir, _ := filepath.Split(source)
 	sourceLen := len(sourceDir)
 
+	// Special handling for relative paths.
+	if source == ".." {
+		sourceLen = 1
+	}
+
 	sendFile := func(p string, fInfo os.FileInfo, err error) error {
 		if err != nil {
 			return fmt.Errorf(i18n.G("Failed to walk path for %s: %s"), p, err)