Merge pull request #1805 from stgraber/main

Fix some BGP issues

Author: hallyn

internal/server/bgp/server.go

@@ -162,7 +162,7 @@ func (s *Server) stop() error {
 		oldPeers[peerUUID] = peer
 	}
 
-	// Remove all the peers (ignore failures).
+	// Remove all the peers.
 	for _, peer := range s.peers {
 		err := s.removePeer(peer.address)
 		if err != nil {

internal/server/network/driver_ovn.go

@@ -3714,12 +3714,12 @@ func (n *ovn) Update(newNetwork api.NetworkPut, targetNode string, clientType re
 		if err != nil {
 			return err
 		}
-	}
-
-	// Setup BGP.
-	err = n.bgpSetup(oldNetwork.Config)
-	if err != nil {
-		return err
+	} else {
+		// Setup BGP.
+		err = n.bgpSetup(oldNetwork.Config)
+		if err != nil {
+			return err
+		}
 	}
 
 	err = n.loadBalancerBGPSetupPrefixes()

internal/server/network/driver_physical.go

@@ -336,9 +336,16 @@ func (n *physical) Update(newNetwork api.NetworkPut, targetNode string, clientTy
 		return err
 	}
 
-	err = n.setup(oldNetwork.Config)
-	if err != nil {
-		return err
+	if !hostNameChanged {
+		err = n.setup(oldNetwork.Config)
+		if err != nil {
+			return err
+		}
+	} else {
+		err = n.setup(nil)
+		if err != nil {
+			return err
+		}
 	}
 
 	// Update OVS bridge entries (for dependent OVN networks).